Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add description and tag to floating ips #925

Merged
merged 2 commits into from
Jul 5, 2021
Merged

✨ add description and tag to floating ips #925

merged 2 commits into from
Jul 5, 2021

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Jun 30, 2021 •
edited
Loading

What this PR does / why we need it:
This PR adds a description and tags to floating ips.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #868

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

Tobias Giese [email protected], Daimler TSS GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 30, 2021
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @tobiasgiese!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @tobiasgiese. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2021
chrischdi
chrischdi reviewed Jun 30, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to make sense 👍 thanks for contributing

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2021
@chrischdi
Copy link
Member

/retitle ✨ add description to floating ips

@tobiasgiese
Copy link
Member Author

/retitle ✨ add description to floating ips

@k8s-ci-robot
Copy link
Contributor

@tobiasgiese: Re-titling can only be requested by trusted users, like repository collaborators.

In response to this:

/retitle ✨ add description to floating ips

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tobiasgiese tobiasgiese changed the title ✨ add description to floating ips ✨ add description to floating ips Jun 30, 2021
@tobiasgiese tobiasgiese changed the title ✨ add description to floating ips ✨ add description and tag to floating ips Jun 30, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Jul 1, 2021

/test pull-cluster-api-provider-openstack-e2e-test

@tobiasgiese
Copy link
Member Author

/test pull-cluster-api-provider-openstack-e2e-test

everything should work, tested it locally

+---------------------+---------------------------------------------------------------------+
| Field               | Value                                                               |
+---------------------+---------------------------------------------------------------------+
| created_at          | 2021-07-01T06:47:49Z                                                |
| description         | Created by cluster-api-provider-openstack cluster c12pc001-c12pc001 |
[...]
| tags                | ['baz', 'caas', 'capo', 'foobar']                                   |
| updated_at          | 2021-07-01T06:48:10Z                                                |
+---------------------+---------------------------------------------------------------------+

@jichenjc
Copy link
Contributor

jichenjc commented Jul 1, 2021

@tobiasgiese for unknown reason
the CI failure ratio is high now ,tracking here
#927

so it should not related to the PR

@tobiasgiese
Copy link
Member Author

@tobiasgiese for unknown reason
the CI failure ratio is high now ,tracking here
#927

so it should not related to the PR

Okay, thanks for the info :)

seanschneeweiss
seanschneeweiss reviewed Jul 1, 2021
View reviewed changes
Copy link
Contributor

@seanschneeweiss seanschneeweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on the first Pull Request in CAPO 🥇.

pkg/cloud/services/networking/floatingip.go Show resolved Hide resolved
@jichenjc
Copy link
Contributor

jichenjc commented Jul 5, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
chrischdi
chrischdi reviewed Jul 5, 2021
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra call to update the tags could also be replaced by implementing our own CreateOptsBuilder, however I'm ok with keeping the separate call to follow the practice used at the other occurencies. Also most won't have any tags set :-)

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@tobiasgiese
Copy link
Member Author

Had to force-push the two commits to add the signoff

@jichenjc
Copy link
Contributor

jichenjc commented Jul 5, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@tobiasgiese
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit a2acda3 into kubernetes-sigs:master Jul 5, 2021
@tobiasgiese tobiasgiese deleted the floating-ip-desc branch July 5, 2021 11:21
This was referenced Jul 5, 2021
Closed
Closed
@tobiasgiese tobiasgiese mentioned this pull request Jul 16, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jichenjc jichenjc jichenjc left review comments

@seanschneeweiss seanschneeweiss seanschneeweiss left review comments

@chrischdi chrischdi chrischdi left review comments

@prankul88 prankul88 Awaiting requested review from prankul88

Assignees

@chrischdi chrischdi

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tobiasgiese @k8s-ci-robot @chrischdi @jichenjc @seanschneeweiss